Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a small bug in
cdefsbefore compiling a CPU kernel.The code would check if a cdef for this kernel already exists, however, it would do so by checking by the Python name instead of the name in C.
Furthermore, I added a space before and a
(after the cname to be searched for, as otherwise if kernels exist which have the name of the new kernel as a part, the new one would not be generated.E.g. if there already is a kernel definition
void LocalSegment_crossing_drift(double s);then the new kernelvoid crossing_drift(double s1, double s2);would never be generated. Searching forf" {cname}("avoids this problem.All
xobjectstests pass, and allxtracktests withContextCpuas well (did not test the other contexts as they are not affected).Checklist
Mandatory:
Optional: